Repository navigation
Add a test for Message::hasEventTimestamp (apache/pulsar-client-cpp#631) - #4
Open
alexey-milovidov wants to merge 3 commits into
Open
alexey-milovidov wants to merge 3 commits into
alexey-milovidov wants to merge 3 commits into
Conversation
`getEventTimestamp` returns 0 both when the producer set no event time and when it explicitly set the Unix epoch. Add `hasEventTimestamp`, mirroring the existing `hasPartitionKey`/`hasOrderingKey`, so callers can tell the two apart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`Message::hasEventTimestamp` is already in the `clickhouse` branch as ea5d830. The merge adds the test from the upstream pull request, `MessageTest.testHasEventTimestamp`. apache#631 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the upstream pull request apache#631 into the
clickhousebranch.Message::hasEventTimestampis already inclickhouseas ea5d830, and the library part of the upstream pull request is identical to it. This pull request adds the remaining part, the testMessageTest.testHasEventTimestamp.Related: apache#631
Related: ClickHouse/ClickHouse#64184
🤖 Generated with Claude Code